feat: resolve Sunday versus feast occurrence (#33) #349

Merged

manlycucumber merged 1 commit from feature/33-sunday-vs-feast into develop

2026-07-02 03:24:17 +00:00

manlycucumber commented

2026-07-02 03:21:33 +00:00

(Migrated from github.com)

Closes #33. Epic #29, issue 4/8.

What

Adds the Sunday / feast-of-the-Lord exclusion (nn. 15, 112b) to
occurrenceOutcome(): a feast of the Lord and a Sunday do not commemorate
each other.

A feast of the Lord taking a Sunday's place → the Sunday is omitted (not
commemorated); symmetric for a Sunday impeding a feast of the Lord.
A feast of Our Lady or a saint is not barred → it still commemorates the
Sunday. So the Immaculate Conception commemorates its Advent Sunday while
the Holy Name (a feast of the Lord) omits it.

"Feast of the Lord" is recognised by the same identity sets that place the
Lord-feast lines of the tier table.

Verification

composer lint · composer analyse (PHPStan L6, no errors) · composer test
(443 tests, 30,266 assertions — +3). Rule verified against 1960 New Rubrics
nn. 15, 112. Commits signed + DCO.

Closes #33. Epic #29, issue 4/8. ## What Adds the **Sunday / feast-of-the-Lord exclusion** (nn. 15, 112b) to `occurrenceOutcome()`: a feast **of the Lord** and a Sunday do **not** commemorate each other. - A feast of the Lord taking a Sunday's place → the Sunday is **omitted** (not commemorated); symmetric for a Sunday impeding a feast of the Lord. - A feast of **Our Lady** or a saint is *not* barred → it still commemorates the Sunday. So the **Immaculate Conception commemorates** its Advent Sunday while the **Holy Name** (a feast of the Lord) **omits** it. "Feast of the Lord" is recognised by the same identity sets that place the Lord-feast lines of the tier table. ## Verification `composer lint` · `composer analyse` (PHPStan L6, no errors) · `composer test` (443 tests, 30,266 assertions — +3). Rule verified against 1960 New Rubrics nn. 15, 112. Commits signed + DCO.

manlycucumber referenced this pull request from a commit

2026-08-05 19:02:29 +00:00

feat: resolve Sunday versus feast occurrence (#33) (#349)

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Directorium/Core!349

No description provided.

Rows
Columns