fix: rank Advent Sundays first class and Advent ferias third class (#428) #436

Merged

manlycucumber merged 2 commits from fix/428-temporal-rank-corrections into develop

2026-07-02 19:57:26 +00:00

manlycucumber commented

2026-07-02 19:53:52 +00:00

(Migrated from github.com)

First slice of the #428 accuracy burndown: the temporal corpus-rank corrections.

What was wrong

The Table of Liturgical Days (Rubricae 1960, n. 91) makes all Sundays of Advent first class and the ferias of Advent up to Dec 16 (outside the Ember days) third class. The corpus under-ranked both:

archetype	was	now	rubric
`advent-sunday` (II & IV)	II	I	Sundays of Advent are I class
`advent-sunday-gaudete` (III)	II	I	(rose privilege retained)
`advent-feria` (to Dec 16)	IV	III	Advent ferias are III class

advent-sunday-i was already correct at I class — a partial earlier fix; this completes it.

Evidence

Both independent oracles corroborate every correction (missalemeum and the SSPX ordo agree on I-class Advent Sundays and III-class Advent ferias). Re-measured: 32 missalemeum and 28 SSPX baselined divergences resolved, 0 regressions.

Also in this PR

Corrected the unit assertions in ChristmasCycleTest / TemporalAttributesTest that had encoded the wrong ranks.
Re-froze the golden-year digest (#365), the golden traces (#240), and both oracle baselines to record the improvement (missalemeum 421→389, SSPX 85→57).

Gate: lint clean · analyse [OK] · test 658 (1 skip) · validate 22 (1 skip).

Refs #428

First slice of the #428 accuracy burndown: the **temporal** corpus-rank corrections. ## What was wrong The Table of Liturgical Days (Rubricae 1960, n. 91) makes **all Sundays of Advent first class** and the **ferias of Advent up to Dec 16** (outside the Ember days) **third class**. The corpus under-ranked both: | archetype | was | now | rubric | |---|---|---|---| | `advent-sunday` (II & IV) | II | **I** | Sundays of Advent are I class | | `advent-sunday-gaudete` (III) | II | **I** | (rose privilege retained) | | `advent-feria` (to Dec 16) | IV | **III** | Advent ferias are III class | `advent-sunday-i` was already correct at I class — a partial earlier fix; this completes it. ## Evidence Both independent oracles corroborate every correction (`missalemeum` **and** the SSPX ordo agree on I-class Advent Sundays and III-class Advent ferias). Re-measured: **32 missalemeum** and **28 SSPX** baselined divergences resolved, **0 regressions**. ## Also in this PR - Corrected the unit assertions in `ChristmasCycleTest` / `TemporalAttributesTest` that had encoded the wrong ranks. - Re-froze the golden-year digest (#365), the golden traces (#240), and both oracle baselines to record the improvement (`missalemeum` 421→389, `SSPX` 85→57). Gate: lint clean · analyse [OK] · test 658 (1 skip) · validate 22 (1 skip). Refs #428

manlycucumber referenced this pull request from a commit

2026-08-05 19:02:29 +00:00

fix: rank Advent Sundays first class and Advent ferias third class (#428) (#436)

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Directorium/Core!436

No description provided.

Rows
Columns