Wire i18n text into the output contract hooks #106
Labels
No labels
area: build
area: ci
area: compare
area: data
area: engine
area: model
area: provenance
area: rite
area: validation
backport
blocked
breaking
confirmed
dependencies
duplicate
epic
github_actions
invalid
needs-info
needs-triage
php
priority: high
priority: low
priority: medium
regression
type: bug
type: chore
type: correction
type: docs
type: enhancement
type: feature
type: fix
type: perf
type: refactor
type: security
wontfix
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Directorium/Core#106
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
The v0.1.0 contract reserved i18n-shaped text and chant/audio hooks. The assembler must populate these hooks so consumers get text through the stable contract.
Acceptance criteria
Notes
No breaking change to the 1.0 contract.
Done in
fd26918— assembled text flows into the reserved dayofficekey.ACs: assembled text populates the i18n text fields ✓ — per-locale leaves under the
officeblock,laalways present; chant/audio hooks populated when content exists else null ✓ —tests/Contract/OfficeI18nTest.php::testContentHooksArePresentAndNullstill pinstext/chant/audio/citationsas present-and-null at day level; contract shape unchanged, additive only ✓ —officeis pinned in the frozen key-set attests/Contract/ContractShapeTest.php:40with its inner key-set pinned at:122/:148,SHAPE_VERSIONremains 1.1.0; test confirms text flows through the contract ✓ —tests/Contract/DayContractTest.php:86.