feat: resolve occurrence for second, third, and fourth class days (#32) #348
No reviewers
Labels
No labels
area: build
area: ci
area: compare
area: data
area: engine
area: model
area: provenance
area: rite
area: validation
backport
blocked
breaking
confirmed
dependencies
duplicate
epic
github_actions
invalid
needs-info
needs-triage
php
priority: high
priority: low
priority: medium
regression
type: bug
type: chore
type: correction
type: docs
type: enhancement
type: feature
type: fix
type: perf
type: refactor
type: security
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Directorium/Core!348
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feature/32-occurrence-lower-classes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #32. Epic #29, issue 3/8.
What
The unified
occurrenceOutcome()built in #31 already resolves the lower-classpairings (one ordered comparison over the tier table). This issue verifies that
behaviour and pins the occurrence boundary it must honour:
Sunday over a II- or III-class feast; a Lenten feria over a third-class feast;
a feria over a fourth-class commemoration;
day it is omitted (a first-class day admits only privileged commemorations,
n. 111a), not moved.
Tests + a design-record note; no production change (the method from #31 covers
these classes).
Verification
composer lint·composer analyse(PHPStan L6, no errors) ·composer test(440 tests, 30,263 assertions — +5). Commits signed + DCO.