feat(office): add the per-office proper-text store and resolve proper parts (Stage 4a) #503

Merged

manlycucumber merged 1 commit from feat/stage4a-proper-text-store into develop 2026-07-19 05:45:38 +00:00

Conversation 0 Commits 1 Files changed 12 +328 -14

manlycucumber commented 2026-07-19 05:29:32 +00:00

Owner

Copy link

Stage 4a — the source-free half of the LOBVM pilot (Stage 4 splits 4a/4b like Stage 2s 2a/2b). A zero-axis-movement change: no office is seeded, so the golden digest, corpusVersion, corpusContentDigest and engineVersion are all unmoved (both freezes zero-diff).

Lands the per-office proper-text store Stage 3 deferred:

• office-proper-text.schema.json — the compiled row (frozen leaf + (textRef, locale) address).
• Corpus::officeProperText() — edition-scoped reader (guarded like officeStructure; API surface re-frozen additively).
• CorpusOfficeTextProvider::proper() — resolves a parts textRef against the store; a proper leaf may withhold, so rows are read through TextLeafs constructors (full → body, degraded → withheld, never a leak); duplicate (textRef, locale) or no-Latin fails closed.
• The office fixture is now a self-contained mini-corpus, assembled end-to-end.

4b (the digest-mover) is source-gated on the Benziger-1915 proper bodies + br-1961 (Open-Q #12) and is not part of this PR.

Validation: workspace composer check green (phpcs + phpstan + 1243 phpunit/1 skip); both freezes zero-diff; generator npm test/build/verify green.

Stage 4a — the source-free half of the LOBVM pilot (Stage 4 splits 4a/4b like Stage 2s 2a/2b). A **zero-axis-movement** change: no office is seeded, so the golden digest, corpusVersion, corpusContentDigest and engineVersion are all unmoved (both freezes zero-diff). Lands the per-office **proper-text store** Stage 3 deferred: - `office-proper-text.schema.json` — the compiled row (frozen leaf + `(textRef, locale)` address). - `Corpus::officeProperText()` — edition-scoped reader (guarded like `officeStructure`; API surface re-frozen additively). - `CorpusOfficeTextProvider::proper()` — resolves a parts `textRef` against the store; a proper leaf may withhold, so rows are read through `TextLeaf`s constructors (full → body, degraded → withheld, never a leak); duplicate `(textRef, locale)` or no-Latin fails closed. - The office fixture is now a self-contained mini-corpus, assembled end-to-end. **4b (the digest-mover) is source-gated** on the Benziger-1915 proper bodies + `br-1961` (Open-Q #12) and is not part of this PR. Validation: workspace `composer check` green (phpcs + phpstan + 1243 phpunit/1 skip); both freezes zero-diff; generator npm test/build/verify green.

manlycucumber added 1 commit 2026-07-19 05:29:32 +00:00

feat(office): add the per-office proper-text store and resolve proper parts (Stage 4a) ... 43646241e5

Stage 4 splits into 4a (source-free store machinery) and 4b (the real
Little-Office seed), mirroring the Stage-2 2a/2b split. 4a is a
zero-axis-movement change: no office is seeded, so the day office key
stays null on every 1962 day and the golden digest, corpusVersion,
corpusContentDigest and engineVersion are all unmoved.

- office-proper-text.schema.json: the compiled proper-text store row --
  the frozen leaf (value|incipit / availability / source / rights) plus
  its (textRef, locale) address, mirroring text-leaf.schema.json.
- Corpus::officeProperText(): the edition-scoped reader for
  editions/<dir>/offices/<slug>/proper-text.ndjson, guarded like
  officeStructure; public API surface re-frozen additively.
- CorpusOfficeTextProvider::proper(): resolves a part's textRef against
  the store into a per-locale leaf map. A proper leaf may withhold, so
  each row is read through TextLeaf's constructors -- a full row yields a
  body, any degraded row a withheld leaf; a duplicate (textRef, locale)
  or a reference with no Latin fails closed.
- The office fixture is now a self-contained mini-corpus: it assembles
  proper text from the store and a psalm from the psalter stream.

The generator ingestion of the real Benziger propers and the born-cited
gate over its bodies land with the seed (4b), where the facts-YAML
co-designs with the data.

manlycucumber force-pushed feat/stage4a-proper-text-store from 43646241e5 to 70f3133860 2026-07-19 05:37:33 +00:00 Compare

manlycucumber merged commit 9e7e41efb3 into develop 2026-07-19 05:45:38 +00:00

manlycucumber referenced this pull request from a commit 2026-07-19 05:45:39 +00:00

Merge pull request 'feat(office): add the per-office proper-text store and resolve proper parts (Stage 4a)' (#503) from feat/stage4a-proper-text-store into develop

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area: build

Build & tooling

  

area: ci

CI / release

  

area: compare

Cross-edition / cross-rite comparison tool

  

area: data

Feast corpus & generators

  

area: engine

Resolver / rules / calendar logic

  

area: model

Structured liturgical models (Ordo Missae, Office, diff)

  

area: provenance

Sources, citations, errata, and the resolution trace

  

area: rite

Multi-rite framework and non-Roman rites

  

area: validation

Oracles & day-by-day tests

  

backport

Cherry-pick into a maintained older line

  

blocked

Blocked until something else resolves

  

breaking

Backward-incompatible change (major bump)

  

confirmed

Reproduced / accepted as real

  

dependencies

Pull requests that update a dependency file

  

duplicate

Duplicate of another issue

  

epic

Epic — tracking issue grouping child issues

  

github_actions

Pull requests that update GitHub Actions code

  

invalid

Not a valid issue

  

needs-info

Waiting on more detail

  

needs-triage

New, not yet reviewed

  

php

Pull requests that update php code

  

priority: high

Do next; urgent or high impact

  

priority: low

Nice to have / someday

  

priority: medium

Normal queue

  

regression

Worked in a previous release

  

type: bug

  

type: chore

Maintenance / internal

  

type: correction

A liturgical-data correction backed by a citation

  

type: docs

Documentation

  

type: enhancement

Improvement to existing behaviour

  

type: feature

New user-facing capability

  

type: fix

Bug fix

  

type: perf

Performance improvement

  

type: refactor

Internal refactor

  

type: security

Security fix

  

wontfix

Will not be worked on

No labels

area: build

area: ci

area: compare

area: data

area: engine

area: model

area: provenance

area: rite

area: validation

backport

blocked

breaking

confirmed

dependencies

duplicate

epic

github_actions

invalid

needs-info

needs-triage

php

priority: high

priority: low

priority: medium

regression

type: bug

type: chore

type: correction

type: docs

type: enhancement

type: feature

type: fix

type: perf

type: refactor

type: security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Directorium/Core!503

No description provided.