feat: apply octave handling for the surviving 1960 octaves (#28) #344

Merged

manlycucumber merged 1 commit from feature/28-octave-handling into develop

2026-07-02 02:29:49 +00:00

manlycucumber commented

2026-07-02 02:28:42 +00:00

(Migrated from github.com)

Closes #28. Epic #23, issue 5/6.

What

Under 1960 only the Christmas, Easter, and Pentecost octaves survive, and all
three are temporal (the block-fillers already emit their days as octave-day
/ within-octave). Every other historical octave was abolished, so the sanctoral
overlay generates no octaves.

This issue locks that behaviour in and checks the interaction (tests + docs; no
production code needed — the overlay's correct octave behaviour is to add
nothing):

the overlay emits no octave-day / within-octave offices;
a day within each of the three surviving octaves is emitted by the temporal
layer as an octave day (Christmas 27 Dec, Easter Monday, Whit Monday);
where a sanctoral feast falls within the Christmas octave (St Stephen, 26 Dec),
the temporal octave day and the sanctoral feast co-occur — the case the resolver
(#29) resolves (feast celebrated, octave commemorated).

Transfers/omissions for feasts impeded by the Easter and Pentecost octaves are #29.

Verification

composer lint · composer analyse (PHPStan L6, no errors) · composer test
(390 tests, 16,593 assertions — +3). Commits signed + DCO.

Closes #28. Epic #23, issue 5/6. ## What Under 1960 only the **Christmas, Easter, and Pentecost** octaves survive, and all three are **temporal** (the block-fillers already emit their days as `octave-day` / `within-octave`). Every other historical octave was abolished, so the sanctoral overlay generates **no** octaves. This issue locks that behaviour in and checks the interaction (tests + docs; no production code needed — the overlay's correct octave behaviour is to add nothing): - the overlay emits no `octave-day` / `within-octave` offices; - a day within each of the three surviving octaves is emitted by the temporal layer as an octave day (Christmas 27 Dec, Easter Monday, Whit Monday); - where a sanctoral feast falls within the Christmas octave (St Stephen, 26 Dec), the temporal octave day and the sanctoral feast co-occur — the case the resolver (#29) resolves (feast celebrated, octave commemorated). Transfers/omissions for feasts impeded by the Easter and Pentecost octaves are #29. ## Verification `composer lint` · `composer analyse` (PHPStan L6, no errors) · `composer test` (390 tests, 16,593 assertions — +3). Commits signed + DCO.

manlycucumber referenced this pull request from a commit

2026-08-05 19:02:29 +00:00

feat: apply octave handling for the surviving 1960 octaves (#28) (#344)

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Directorium/Core!344

No description provided.

Rows
Columns