Stage 2a: text-ingestion core — NFC, verse-keying, versification-mismatch #498

Merged

manlycucumber merged 1 commit from feat/text-ingestion into develop 2026-07-18 06:38:32 +00:00

Conversation 0 Commits 1 Files changed 4 +361

manlycucumber commented 2026-07-18 06:38:31 +00:00

Owner

Copy link

Decision-free half of Stage 2 (§4.2, #112-#114): the format-agnostic ingestion library ingest.mjs (NFC normalization, ingestVerse/ingestPsalter with integer-verse + mandatory-locator + dedup fail-closed + deterministic sort, detectVersificationMismatch for #114), the psalter-verse stream-row schema, and synthetic tests (81 generator tests). Born-cited gate enforces the Venite fail-closed policy (a reference-only source can never transcribe a verse). No real text yet — Stage 2b is gated on Open-Q #10 (imprints) and #12 (Venite Gallican/Romanum + full-psalter ERRATA). No corpus/golden/PHP surface moves; cockpit-validated (npm test + verify). Signed commit 04f37a2.

Decision-free half of Stage 2 (§4.2, #112-#114): the format-agnostic ingestion library `ingest.mjs` (NFC normalization, `ingestVerse`/`ingestPsalter` with integer-verse + mandatory-locator + dedup fail-closed + deterministic sort, `detectVersificationMismatch` for #114), the `psalter-verse` stream-row schema, and synthetic tests (81 generator tests). Born-cited gate enforces the Venite fail-closed policy (a reference-only source can never transcribe a verse). No real text yet — Stage 2b is gated on Open-Q #10 (imprints) and #12 (Venite Gallican/Romanum + full-psalter ERRATA). No corpus/golden/PHP surface moves; cockpit-validated (npm test + verify). Signed commit `04f37a2`.

manlycucumber added 1 commit 2026-07-18 06:38:32 +00:00

feat(text): ingestion core — NFC, verse-keying, versification-mismatch (Stage 2a) ... 04f37a2adb

The decision-free half of Stage 2 (office-text-layer.md §4.2, #112-#114): the format-agnostic
text-ingestion library `tools/generator/src/ingest.mjs` — `nfc` NFC normalization (the new
ingest-boundary requirement §8/#112), `ingestVerse`/`ingestPsalter` (integer-verse enforcement,
mandatory scan-locator, dedup fail-closed, deterministic psalm:verse sort), and
`detectVersificationMismatch` (#114: detect + report Latin/English divergence, never silently
pair) — plus the `psalter-verse` stream-row schema (the frozen text-leaf fill-shape + the
psalm:verse address) and thorough synthetic tests (81 generator tests total).

It never decides provenance: a verse becomes a `full` leaf cited to a PD `text` source with a
locator, so the born-cited gate enforces the §4.2c Venite fail-closed policy — a reference-only
source (br-1961) can never transcribe a verse. No real psalter text yet: Stage 2b (the source
parsers + vendored PD text) is gated on the imprint (#10) and Venite/ERRATA (#12) decisions.
No corpus data, golden, or PHP surface moves — validated on the cockpit (npm test + verify).

manlycucumber merged commit 5d5daf88d3 into develop 2026-07-18 06:38:32 +00:00

manlycucumber referenced this pull request from a commit 2026-07-18 06:38:33 +00:00

Merge Stage 2a: text-ingestion core (#498)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area: build

Build & tooling

  

area: ci

CI / release

  

area: compare

Cross-edition / cross-rite comparison tool

  

area: data

Feast corpus & generators

  

area: engine

Resolver / rules / calendar logic

  

area: model

Structured liturgical models (Ordo Missae, Office, diff)

  

area: provenance

Sources, citations, errata, and the resolution trace

  

area: rite

Multi-rite framework and non-Roman rites

  

area: validation

Oracles & day-by-day tests

  

backport

Cherry-pick into a maintained older line

  

blocked

Blocked until something else resolves

  

breaking

Backward-incompatible change (major bump)

  

confirmed

Reproduced / accepted as real

  

dependencies

Pull requests that update a dependency file

  

duplicate

Duplicate of another issue

  

epic

Epic — tracking issue grouping child issues

  

github_actions

Pull requests that update GitHub Actions code

  

invalid

Not a valid issue

  

needs-info

Waiting on more detail

  

needs-triage

New, not yet reviewed

  

php

Pull requests that update php code

  

priority: high

Do next; urgent or high impact

  

priority: low

Nice to have / someday

  

priority: medium

Normal queue

  

regression

Worked in a previous release

  

type: bug

  

type: chore

Maintenance / internal

  

type: correction

A liturgical-data correction backed by a citation

  

type: docs

Documentation

  

type: enhancement

Improvement to existing behaviour

  

type: feature

New user-facing capability

  

type: fix

Bug fix

  

type: perf

Performance improvement

  

type: refactor

Internal refactor

  

type: security

Security fix

  

wontfix

Will not be worked on

No labels

area: build

area: ci

area: compare

area: data

area: engine

area: model

area: provenance

area: rite

area: validation

backport

blocked

breaking

confirmed

dependencies

duplicate

epic

github_actions

invalid

needs-info

needs-triage

php

priority: high

priority: low

priority: medium

regression

type: bug

type: chore

type: correction

type: docs

type: enhancement

type: feature

type: fix

type: perf

type: refactor

type: security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Directorium/Core!498

No description provided.