feat(office): seed the Little Office BVM per-annum Lauds (Stage 4b) #504

Merged

manlycucumber merged 5 commits from feat/stage4b-lobvm-lauds-seed into develop 2026-07-20 02:30:40 +00:00

Conversation 0 Commits 5 Files changed 20 +1325 -646

manlycucumber commented 2026-07-20 01:59:46 +00:00

Owner

Copy link

Stage 4b — the LOBVM pilot, and the first reviewed golden-digest move.

Seeds the per-annum Lauds of the Little Office BVM into the base 1962 corpus: a 16-part structure + 10 bilingual proper leaves (5 antiphons, capitulum, hymn O gloriósa vírginum, versicle, Benedictus-antiphon, collect). Latin transcribed from the Benziger 1915 page-scans (lobvm-benziger-1915, PD; two-pass scan re-verification, 5 self-caught corrections), English from the Wikisource proofread text; each leaf cited to its printed page. Psalms (92/99/62/148) + canticles (daniel:3:57-88, luke:1:68-79) reference the Stage-2 streams.

• Built the proper-text generator emit side (Stage 4a shipped only the reader): transformOfficeProperText + born-cited gating.
• Office resolves on every day (a parallel votive cursus); resolution memoised (day-independent) to keep the ~225k-day freeze tractable — output unchanged.
• goldenDigest e64d2dfc → 33a2f471 — corpus-driven: corpusVersion 1962-2026-07-18.4 → 1962-2026-07-19.1, engineVersion stays 0.5.0; freeze accepted under GoldenProvenanceLock.
• Validated: generator npm test 101 green + byte-reproducible; composer check green (1247 tests, phpcs + phpstan clean).

Decisions (maintainer): accents preserved, intonation asterisks dropped from stored values. Pilot simplifications flagged in the facts file (per-annum only; Benedicite = daniel:3:57-88; Paschal Benedictus-ant substitution deferred; ℣/℟ collapsed). Provenance & decisions: docs/design/drafts/lobvm-lauds-per-annum-draft.md.

Stage 4b — the LOBVM pilot, and the **first reviewed golden-digest move**. Seeds the per-annum **Lauds** of the Little Office BVM into the base 1962 corpus: a 16-part structure + 10 bilingual proper leaves (5 antiphons, capitulum, hymn *O gloriósa vírginum*, versicle, Benedictus-antiphon, collect). Latin transcribed from the Benziger 1915 page-scans (`lobvm-benziger-1915`, PD; two-pass scan re-verification, 5 self-caught corrections), English from the Wikisource proofread text; each leaf cited to its printed page. Psalms (92/99/62/148) + canticles (daniel:3:57-88, luke:1:68-79) reference the Stage-2 streams. - Built the proper-text generator **emit** side (Stage 4a shipped only the reader): `transformOfficeProperText` + born-cited gating. - Office resolves on every day (a parallel votive cursus); resolution **memoised** (day-independent) to keep the ~225k-day freeze tractable — output unchanged. - **goldenDigest `e64d2dfc → 33a2f471`** — corpus-driven: corpusVersion `1962-2026-07-18.4 → 1962-2026-07-19.1`, engineVersion stays 0.5.0; freeze accepted under GoldenProvenanceLock. - Validated: generator `npm test` 101 green + byte-reproducible; `composer check` green (1247 tests, phpcs + phpstan clean). Decisions (maintainer): accents preserved, intonation asterisks dropped from stored values. Pilot simplifications flagged in the facts file (per-annum only; Benedicite = `daniel:3:57-88`; Paschal Benedictus-ant substitution deferred; ℣/℟ collapsed). Provenance & decisions: `docs/design/drafts/lobvm-lauds-per-annum-draft.md`.

manlycucumber added 4 commits 2026-07-20 01:59:46 +00:00

feat(office): seed the Little Office BVM per-annum Lauds (Stage 4b) ... f2663cc969

Author facts/editions/roman-rubricae-1960/offices/little-office-bvm.yaml: the
per-annum Lauds structure (16 parts — antiphon#1-6, Ps 92/99/62/148, canticles
daniel:3:57-88 [Benedicite] and luke:1:68-79 [Benedictus], chapter/hymn/versicle/
collect) and the 10 bilingual proper leaves.

Latin transcribed from the Benziger 1915 page-scans (lobvm-benziger-1915, PD),
English from the Wikisource proofread text; each leaf cited to its printed-page
locator. Structure shape per catholic-encyclopedia-1910 + the psalm scheme the
book prints. Two-pass scan re-verification corrected 5 leaves to match Benziger.

Build the proper-text generator EMIT side (Stage 4a shipped only the reader):
transformOfficeProperText fans inline text into frozen §4.1 leaves (NFC,
source/rights stamped, born-cited gated); transformOffice meta now emits seasons;
wired through build.mjs (emit proper-text.ndjson, validate, provenance gate).

corpusVersion 1962-2026-07-18.4 -> 1962-2026-07-19.1 (corpus-driven). Generator
npm test 101 green, build byte-reproducible, the born-cited gate accepts the
leaves. Decisions: accents preserved, intonation asterisks dropped from values.

The golden re-freeze + contract-test expectations land in the follow-up commit.

perf(office): memoise the day-independent office and retarget tests to the seed ... 7c1cd4ed14

The Little Office resolves on every day, but its assembly is day-independent in v1.2
(fixed edition + the single per-annum season). Memoise OfficeResolver::resolve() so a
resolver reused across a year's days assembles ONCE — the golden freeze resolves ~225k
days (1584-2200), and without the memo each re-scans the psalter/canticle streams. Output
is identical; this is a pure speed change, so the digest move stays corpus-driven.

Retarget the tests the seeded office now flips from null to a filled block:
- OfficeResolverTest: the base 1962 edition now resolves the seeded LOBVM (was asserted
  null); + a memoisation guard (resolve() returns the same instance).
- ContractShapeTest: the day-level office block is now non-null on the shipped corpus —
  pin its key-set (content byte-frozen by the golden fixture); the synthetic shape pin stays.
- DayContractTest: pin the rest of the contract exactly with the office removed, then pin the
  office block shape + the first antiphon's Latin as a fast drift check.

test(office): retarget corpus + provider tests to the seeded LOBVM office ... 4d55d1c9c1

The base 1962 corpus now declares the Little Office (Stage 4b), so two tests that
asserted the pre-seed empty state flip:
- CorpusTest: officeSlugs is ['little-office-bvm'] and the structure + proper-text
  stores are non-empty (was asserted empty).
- CorpusOfficeTextProviderTest: proper() resolves antiphon#1 bilingually from the
  store (was asserted to fail closed); pin its Latin + source as a drift check.

chore(golden): re-freeze the golden year for the LOBVM Lauds seed ... a7476f5c35

The first reviewed golden-digest move: the base 1962 corpus now resolves the per-annum Little Office Lauds on every day (1584-2200). goldenDigest e64d2dfc->33a2f471, corpusContentDigest 40ee75cb->72f2d035, corpusVersion 1962-2026-07-18.4->1962-2026-07-19.1. Corpus-driven (MANIFEST delta), so engineVersion stays 0.5.0; the freeze accepted the move under the GoldenProvenanceLock.

manlycucumber added 1 commit 2026-07-20 02:21:37 +00:00

fix(provenance): enforce a scan locator on text-leaf citations (§4.4) ... d073227b01

An adversarial review found the born-cited gate verified a proper leaf's `value`
cited a public-domain `text` source but NOT the "with a locator" half — it was
convention-only, though office-proper-text.schema.json's description and build.mjs's
comments both claimed the gate enforced it. The verse path already hard-throws on a
missing locator (ingest.mjs §4.4); the office proper-text emit, newly wired through
checkProvenance in this branch, did not.

The gate now requires every value/incipit citation to carry a ':locator', so a future
locator-less proper cite fails the build instead of silently shipping unlocated sacred
text. All 20 seeded LOBVM leaves already carry page locators (p.160–p.193), so the
corpus and golden digest are unmoved. Schema description updated to state the
enforcement is live; + a generator test for the locator-less case.

manlycucumber merged commit 3727b6b1fc into develop 2026-07-20 02:30:40 +00:00

manlycucumber deleted branch feat/stage4b-lobvm-lauds-seed 2026-07-20 02:30:40 +00:00

manlycucumber referenced this pull request from a commit 2026-07-20 02:30:41 +00:00

Merge pull request 'feat(office): seed the Little Office BVM per-annum Lauds (Stage 4b)' (#504) from feat/stage4b-lobvm-lauds-seed into develop

manlycucumber referenced this pull request 2026-07-20 03:10:38 +00:00

feat(office): seed the Little Office BVM per-annum Little Hours (Stage 4b) #505

manlycucumber referenced this pull request 2026-07-20 04:03:59 +00:00

feat(office): seed the Little Office BVM per-annum Vespers + Compline (Stage 4b) #506

manlycucumber referenced this pull request 2026-07-20 04:39:51 +00:00

feat(office): seed the Little Office BVM per-annum Matins (Stage 4b) #507

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area: build

Build & tooling

  

area: ci

CI / release

  

area: compare

Cross-edition / cross-rite comparison tool

  

area: data

Feast corpus & generators

  

area: engine

Resolver / rules / calendar logic

  

area: model

Structured liturgical models (Ordo Missae, Office, diff)

  

area: provenance

Sources, citations, errata, and the resolution trace

  

area: rite

Multi-rite framework and non-Roman rites

  

area: validation

Oracles & day-by-day tests

  

backport

Cherry-pick into a maintained older line

  

blocked

Blocked until something else resolves

  

breaking

Backward-incompatible change (major bump)

  

confirmed

Reproduced / accepted as real

  

dependencies

Pull requests that update a dependency file

  

duplicate

Duplicate of another issue

  

epic

Epic — tracking issue grouping child issues

  

github_actions

Pull requests that update GitHub Actions code

  

invalid

Not a valid issue

  

needs-info

Waiting on more detail

  

needs-triage

New, not yet reviewed

  

php

Pull requests that update php code

  

priority: high

Do next; urgent or high impact

  

priority: low

Nice to have / someday

  

priority: medium

Normal queue

  

regression

Worked in a previous release

  

type: bug

  

type: chore

Maintenance / internal

  

type: correction

A liturgical-data correction backed by a citation

  

type: docs

Documentation

  

type: enhancement

Improvement to existing behaviour

  

type: feature

New user-facing capability

  

type: fix

Bug fix

  

type: perf

Performance improvement

  

type: refactor

Internal refactor

  

type: security

Security fix

  

wontfix

Will not be worked on

No labels

area: build

area: ci

area: compare

area: data

area: engine

area: model

area: provenance

area: rite

area: validation

backport

blocked

breaking

confirmed

dependencies

duplicate

epic

github_actions

invalid

needs-info

needs-triage

php

priority: high

priority: low

priority: medium

regression

type: bug

type: chore

type: correction

type: docs

type: enhancement

type: feature

type: fix

type: perf

type: refactor

type: security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Directorium/Core!504

No description provided.