feat: resolve concurrence of First and Second Vespers (#35) #351
No reviewers
Labels
No labels
area: build
area: ci
area: compare
area: data
area: engine
area: model
area: provenance
area: rite
area: validation
backport
blocked
breaking
confirmed
dependencies
duplicate
epic
github_actions
invalid
needs-info
needs-triage
php
priority: high
priority: low
priority: medium
regression
type: bug
type: chore
type: correction
type: docs
type: enhancement
type: feature
type: fix
type: perf
type: refactor
type: security
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Directorium/Core!351
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feature/35-vespers-concurrence"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #35. Epic #29, issue 6/8.
What
Adds
ConcurrenceOutcomeandPrecedenceRules::concurrenceOutcome(). The eveningbetween two adjacent days resolves to one of four outcomes:
(a capitulo de sequenti);
Scope
v0.1.0 is calendar-level (no Divine Office), so this reports which office
holds the evening and which is commemorated. The finer Table of Concurrence
rulings and the Triduum's proper Vespers arrive with the Office layer; the
LiturgicalDay::secondVespers()accessor that surfaces this is added in #37.Verification
composer lint·composer analyse(PHPStan L6, no errors) ·composer test(456 tests, 30,293 assertions — +14). Commits signed + DCO.